Repository navigation
mod_autoindex: don't read past the end of a file description - #812
Open
arshsmith1 wants to merge 1 commit into
Open
arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
Collaborator
|
Test case? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminate_description() in mod_autoindex walks a file's description one character at a time, and when a description ends inside an unterminated
&entity or<tag the inner scan loop stops on the terminating NUL and the outer loop'sx++then moves one byte past it, so the following loop condition reads, and the "Grump" truncation block can write, just beyond the string. WithIndexOptions ScanHTMLTitlesthe description is the file's<title>(find_title cuts it at the first<but it can still contain a bare&, as in "AT&T" or "R&D"), so a served file whose title an untrusted user controls can trigger it; AddressSanitizer reports a 1-byte heap read right after the allocation. The fix stops both scan loops at the NUL and breaks out of the outer loop there, soxnever advances past the terminator and the output stays identical for every well-formed description.vulnerability (see
SECURITY.mdand https://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time
(see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).